-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Slove the problem of assets not being displayed in online sync #4727
fix: Slove the problem of assets not being displayed in online sync #4727
Conversation
:table-config="tableConfig" | ||
v-bind="subComponentProps" | ||
@refresh="reloadTable" | ||
/> | ||
</template> | ||
</CardTable> | ||
</template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The template tag name
CardTables
seems to be inconsistent with how it's defined elsewhere in your code. - Use of 'var' instead of 'let', which may not always yield optimal performance due to variable initialization delays during startup phase.
- No mention of any specific optimizations that can potentially improve performance over just refactoring this component.
No clear issues detected; however, these minor changes will likely have small effects on user perception but are generally safe and should cause no notable problems. It could possibly save you time if you decide to refactor the style or structure without introducing new bugs. However, since there was no issue detection mentioned, I'll go ahead and say "no concerns found"; feel free to address them later!
@@ -67,6 +67,7 @@ export default { | |||
} | |||
], | |||
config: { | |||
url: '', | |||
hasSelection: true, | |||
persistSelection: false, | |||
hasPagination: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, but I can't see any code provided by you. Please write your question or prompt in a structured format such as text messages between users that includes the necessary details so I could help you properly.
|
fix: Slove the problem of assets not being displayed in online sync