perf: Optimize the display of labels in strategy actions #4646
Conversation
| } | ||
| return { label: label, value: item.id } | ||
| return { label: display, value: item.id } | ||
| } | ||
| }, | ||
| multiple: false |
There was a problem hiding this comment.
The code you provided contains slight inconsistencies that might cause errors or unexpected behavior when testing on various environments or browsers. I recommend fixing these discrepancies to improve the overall quality of your application:
-
The
cleanFormValuefunction should properly update properties from local storage if it's used instead of re-rendering components. -
Make sure to import all necessary dependencies at the beginning of each file, such as
@ngneat/formly. -
Add type definitions for reusable components like
GlobalResourceTableComponentandGlobalProtocolTableComponentif needed. -
Consider using Vue CLI tools to help with development and maintainability.
To optimize further:
5. If the form validation is not being passed down correctly, consider moving the logic into another component to avoid unnecessary calls across components.
6. Implement proper input validation and data sanitization measures based on security practices.
Lastly, ensure that the globalProtocols, globalResource, resourceType, and their associated values comply with standard naming conventions and structure.
|
BaiJiangJie
deleted the
pr@dev@perf_strategy_action_label_same_name_display
branch
perf: Optimize the display of labels in strategy actions