Add similar_array_type for LinearAlgebra.Diagonal #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 89.66% 90.70% +1.04%
==========================================
Files 23 23
Lines 2157 2108 -49
==========================================
- Hits 1934 1912 -22
+ Misses 223 196 -27 ☔ View full report in Codecov by Sentry. |
|
Maybe it's best to implement these things in ArrayInterface: JuliaArrays/ArrayInterface.jl#397 and then use ArrayInterface here |
Sure. But can we merge this as a current bug-fix? |
blegat
reviewed
Mar 22, 2023
Actually I made this comment yesterday after the inline comments but they were pending. We can merge with the suggested change |
odow
changed the title
odow
force-pushed
the
od/similar-array-type
branch
from
84fe2e6
to
4fc1169
Compare
odow
commented
Nov 27, 2023
odow
commented
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces jump-dev/JuMP.jl#3295
Part of #206