Skip to content

Fix method ambiguity detected by Julia v1.3 #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Conversation

blegat
Copy link
Member

@blegat blegat commented Sep 20, 2019

Closes #854

@blegat blegat added this to the v0.9.3 milestone Sep 20, 2019
@codecov-io
Copy link

codecov-io commented Sep 20, 2019

Codecov Report

Merging #891 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
- Coverage    95.1%   95.09%   -0.02%     
==========================================
  Files          80       80              
  Lines        8481     8762     +281     
==========================================
+ Hits         8066     8332     +266     
- Misses        415      430      +15
Impacted Files Coverage Δ
src/Utilities/model.jl 94.63% <ø> (-0.27%) ⬇️
src/Bridges/Constraint/scalarize.jl 77.55% <0%> (-2.45%) ⬇️
src/Utilities/functions.jl 94.06% <0%> (+0.05%) ⬆️
src/Bridges/bridge_optimizer.jl 95.75% <0%> (+0.15%) ⬆️
src/Bridges/lazy_bridge_optimizer.jl 93.33% <0%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178c3aa...7712852. Read the comment docs.

@blegat blegat merged commit d486463 into master Sep 20, 2019
@blegat blegat deleted the bl/julia-v1.3-ambiguity branch October 10, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous methods for supports_constraint
2 participants