[Bridges] remove reduce_bridged in favor of explicit methods #1937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Jul 7, 2022
1 task
blegat
reviewed
Sep 8, 2022
| true, | ||
| () -> MOI.supports(b.model, attr, IndexType), | ||
| ok -> | ||
| ok && MOI.supports( |
There was a problem hiding this comment.
@odow Maybe that needed to be || and we can keep your translation below and just revert the if and return to reflect that
There was a problem hiding this comment.
Hmm. Potentially. I refactored these methods because they were impenetrable, and I really didn't understand what they were trying to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chipping away at #1504, and the complications are largely limited to
bridge_optimizer.jl. Thisreduce_bridgedmethod confuses me everything I read it, because it uses too many magic anonymous function calls.