-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep for v1.3.0 #3066
Prep for v1.3.0 #3066
Conversation
Codecov ReportBase: 97.62% // Head: 97.62% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #3066 +/- ##
=======================================
Coverage 97.62% 97.62%
=======================================
Files 32 32
Lines 4297 4297
=======================================
Hits 4195 4195
Misses 102 102 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, it's a new feature and not a bug fix so it should be a minor release but we can make an exception
Semver is pretty clear:
Why not follow it? |
There's an open question whether this should be v1.2.2 or v1.3.0 (the new feature is adding slicing to
SparseAxisArray
). It feels like a minor enough addition that we can just keep v1.2.2 since this is mainly bug fixes and maintenance.