Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for v1.3.0 #3066

Merged
merged 2 commits into from
Sep 4, 2022
Merged

Prep for v1.3.0 #3066

merged 2 commits into from
Sep 4, 2022

Conversation

odow
Copy link
Member

@odow odow commented Sep 1, 2022

There's an open question whether this should be v1.2.2 or v1.3.0 (the new feature is adding slicing to SparseAxisArray). It feels like a minor enough addition that we can just keep v1.2.2 since this is mainly bug fixes and maintenance.

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Base: 97.62% // Head: 97.62% // No change to project coverage 👍

Coverage data is based on head (212d022) compared to base (f92ac03).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3066   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files          32       32           
  Lines        4297     4297           
=======================================
  Hits         4195     4195           
  Misses        102      102           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow
Copy link
Member Author

odow commented Sep 2, 2022

@blegat / @mlubin thoughts on what constitutes a minor release?

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, it's a new feature and not a bug fix so it should be a minor release but we can make an exception

@mlubin
Copy link
Member

mlubin commented Sep 3, 2022

Semver is pretty clear:

Given a version number MAJOR.MINOR.PATCH, increment the:

MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backwards compatible manner
PATCH version when you make backwards compatible bug fixes

Why not follow it?

@odow odow changed the title Prep for v1.2.2 Prep for v1.3.0 Sep 4, 2022
@odow odow merged commit b2502d0 into master Sep 4, 2022
@odow odow deleted the od/v1.2.2 branch September 4, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants