-
Notifications
You must be signed in to change notification settings - Fork 14
More examples #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More examples #95
Conversation
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 86.20% 86.20%
=======================================
Files 6 6
Lines 754 754
=======================================
Hits 650 650
Misses 104 104
Continue to review full report at Codecov.
|
any idea why this is failing on ubuntu nightly here - https://github.com/jump-dev/DiffOpt.jl/pull/95/checks?check_run_id=3069249982#step:7:374 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 - Can you mark the issues that are going to be closed after this is merged?
2 - I see we have a few duplicates in docs and examples folder. We should unify those with literate! (this PR shows hot to do it: joaquimg/BilevelJuMP.jl#121)
PS. with literate you write a .jl file with appropriate comments that get converted into a nice HTML, then you can download in .jl version or even in notebook version.
It is in general easier to make small PRs that are merged within a few days rather than huge PRs that do many different things. |
No description provided.