Skip to content

More examples #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Dec 6, 2021
Merged

More examples #95

merged 28 commits into from
Dec 6, 2021

Conversation

akshay326
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 23, 2021

Codecov Report

Merging #95 (40adc7f) into master (67e8b6f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files           6        6           
  Lines         754      754           
=======================================
  Hits          650      650           
  Misses        104      104           
Impacted Files Coverage Δ
src/diff_opt.jl 88.52% <ø> (-0.28%) ⬇️
src/jump_moi_overloads.jl 64.63% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e8b6f...40adc7f. Read the comment docs.

@akshay326
Copy link
Collaborator Author

any idea why this is failing on ubuntu nightly here - https://github.com/jump-dev/DiffOpt.jl/pull/95/checks?check_run_id=3069249982#step:7:374

Copy link
Member

@joaquimg joaquimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 - Can you mark the issues that are going to be closed after this is merged?

2 - I see we have a few duplicates in docs and examples folder. We should unify those with literate! (this PR shows hot to do it: joaquimg/BilevelJuMP.jl#121)

PS. with literate you write a .jl file with appropriate comments that get converted into a nice HTML, then you can download in .jl version or even in notebook version.

@blegat
Copy link
Member

blegat commented Jul 16, 2021

It is in general easier to make small PRs that are merged within a few days rather than huge PRs that do many different things.
With large PRs, it is difficult to review and to keep track of what is changing in the project. Could you maybe split this into smaller PRs ? For instance, one PR could be setting up Literate.jl and then you can do one PR per added example.

@joaquimg joaquimg mentioned this pull request Dec 4, 2021
@joaquimg joaquimg merged commit 8d572c6 into master Dec 6, 2021
@matbesancon
Copy link
Collaborator

@joaquimg didn't you want to close this one instead if you merged #164 ?

@joaquimg
Copy link
Member

joaquimg commented Dec 6, 2021

This is a bit misleading.
I merged #164, and only #164. But #164 was built on top of this, so this never went to master directly. It went to #164 then to master.

@joaquimg joaquimg deleted the more_examples branch December 7, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants