-
Notifications
You must be signed in to change notification settings - Fork 14
Pass attributes through Objective.FunctionConversionBridge #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
==========================================
+ Coverage 89.08% 89.20% +0.12%
==========================================
Files 15 15
Lines 1969 1973 +4
==========================================
+ Hits 1754 1760 +6
+ Misses 215 213 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I am still getting the same error (I think) in your branch using the example from the issue:
|
Should be fixed now |
First example runs with no errors!
But this could be a different issue! |
I got the same error, this is because MOI.set.(
model,
DiffOpt.ForwardConstraintFunction(),
c3,
sum(x) + 1,
) is incorrect (the correct one is given in #285 (comment)). First, no need to broadcast because every argument is scalar. |
* fix conic error * use jump psd problem * [docs] update to Documenter@1 (#286) * [docs] update to Documenter@1 * Update * update * format * Pass attributes through Objective.FunctionConversionBridge (#287) * Pass attributes through Objective.FunctionConversionBridge * Fix * add test * fix tol * fix test * add reverse test --------- Co-authored-by: joaquimg <joaquimdgarcia@gmail.com> * bump POI * cleanup --------- Co-authored-by: Oscar Dowson <odow@users.noreply.github.com> Co-authored-by: Benoît Legat <benoit.legat@gmail.com> Co-authored-by: joaquimg <joaquimdgarcia@gmail.com>
@andrewrosemberg Can you check if this fixes your issue ?
Closes #285