Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support Julia 1.0 #239

Merged
merged 15 commits into from
Nov 5, 2018
Merged

Update to support Julia 1.0 #239

merged 15 commits into from
Nov 5, 2018

Commits on Oct 30, 2018

  1. updated code to julia 1.0

    little changes + ECOS is now the first tested Solver
    
    norm is imported
    
    norm is restored
    
    starting fixing tests
    
    undefined arrays fixed
    
    testing diag function
    
    import Base./
    
    iterate implemented + import functions from LinearAlgebra
    
    many tests are fixed up to test_sdp.jl
    
    fix diagm
    
    diagm fixed in tests
    
    +(::Array{Float64,2}, ::Float64) fixed
    
    +(x::Array{Float64,2}, y::Number) implemented
    
    diagm is fixed in sdp_constraints.jl
    
    fix norm function
    
    assert is fixed in power_to_socp.jl
    
    all assert issues fixed in power_to_socp.jl
    
    cat function fixed in stack.jl
    
    test_socp.jl fixed
    
    test_params.jl fixed
    
    fixes based on review
    
    explicit solver is added to Problem function
    
    order of arguments changed in Problem function
    
    evaluate(x::AdditionAtom) fixed, starting rewriting tests
    
    evaluate(x::AdditionAtom) fixed
    
    satisfy function is fixed
    
    ArgumentError implemented to diagm function
    
    fix! function is fixed
    
    fix! fixed again
    
    diagandlowerpart in conic_form! function is fixed
    
    hvcat implemented for types AbstractExpr & AbstractExprOrValue
    
    hvcat fixed
    
    hvcat exported
    
    solver argument removed from Problem function
    
    type Problem fixed
    
    argument order in function Problem restored
    
    eye functions fixed
    
    trace => tr fixed
    
    trace => tr fixed in tests
    
    norm => opnorm fixed in operatornorm.jl
    
    fixing tests finished
    
    replacing Diagonal
    
    reduce redundancy of hvcat
    
    stack.jl cleaned
    
    fix test failures due to random seed in test_lp.jl
    
    reducing conv threshold of SCSSolver to 1e-12
    
    reducing conv threshold of SCSSolver to 1e-12
    
    skip problematic max/min atom tests for SCS solver
    
    several changes based on second round of review
    
    ctranspose => adjoint & CTransposeAtom => AdjointAtom
    
    comment out hvcat
    
    uncomment hvcat
    
    trying to fix tests for SCS solver
    
    tests for SCS solver fixed
    
    comment in add_subtract.jl added + deprecated.jl removed
    
    hcat/vcat/vect with Value arguments commented out
    
    hcat uncommented
    
    uncomment vcat
    
    uncomment vect
    
    test vect
    
    test vcat
    
    stack.jl cleaned
    
    dims=1 => dims=Val(1) for vcat and dim=2 => dims=Val(2) for hcat with
    Value arguments
    
    changes in index.jl & fixed mutable struct in power_to_socp.jl
    Letif Mones authored and iamed2 committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    3138f31 View commit details
    Browse the repository at this point in the history
  2. Set the SCS lower bound for testing to 0.4.0

    It was upper bounded at 0.4.0 for Julia 0.6 support.
    ararslan committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    e311885 View commit details
    Browse the repository at this point in the history
  3. srand is now Random.seed!

    ararslan committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    45b8f12 View commit details
    Browse the repository at this point in the history
  4. Remove unused dependency on Compat

    The package no longer supports Julia 0.6 or earlier.
    ararslan committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    7dcf8ff View commit details
    Browse the repository at this point in the history
  5. Extend diagm for AbstractExpr using the Pair interface

    This is consistent with how one otherwise uses diagm.
    ararslan committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    fe5b46d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f317d50 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fc82a2c View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2018

  1. Merge pull request #2 from invenia/aa/more-1.0

    More updates for Julia 1.0
    omus authored Oct 31, 2018
    Configuration menu
    Copy the full SHA
    8f0696b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a033f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2018

  1. Remove testing on Julia nightly

    This is in keeping with general JuliaOpt practices.
    ararslan committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    530feed View commit details
    Browse the repository at this point in the history
  2. Remove introduced mutability of SimpleInequalityExpression

    It was changed amongst the other 1.0 compatibility changes but does not
    seem to be necessary.
    ararslan committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    f111790 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2018

  1. Configuration menu
    Copy the full SHA
    c851ac9 View commit details
    Browse the repository at this point in the history
  2. Overload broadcasted instead of broadcast

    This fixes the case where an `AbstractExpr` occursin in a fused
    broadcast expresion.
    ararslan committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    b3396fb View commit details
    Browse the repository at this point in the history
  3. Merge pull request #6 from invenia/aa/broadcasted

    Overload broadcasted instead of broadcast
    iamed2 authored Nov 2, 2018
    Configuration menu
    Copy the full SHA
    9fb4107 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #5 from invenia/aa/fix-vect

    Don't overwrite Base.vect for numbers with a different implementation
    iamed2 authored Nov 2, 2018
    Configuration menu
    Copy the full SHA
    0018ab9 View commit details
    Browse the repository at this point in the history