forked from Velocidex/velociraptor
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Notifications are throttled now. Refactor VQLCollectorArgs compiler. (V…
…elocidex#958) This change controls the rate of notifications in the notifications service. Usually when a new hunt is created, the notifier notifies all the clients immediately so they can re-connect and receive the next hunt. On very large deployments this causes a bottleneck and a slow down of the server. To address this issue we 1. Limit the rate of notifications to ensure not all clients are reconnecting at the same time. 2. Limit the total connection rate to ensure the server is not overwhelmed. This simply returns 500 when the connection rate is exceeded. Additionally this PR changes the way tools are passed to the VQLCollectorArgs when the artifact is compiled. Previously tool information was passed in the global artifact's env (e.g. Tool_XXX_HASH), and we relies on the previous behaviour that all dependent artifacts shared the root scope. However in recent releases dependent artifacts are running in an isolated scope and so can not see the tool information. This change sets the tool information as a parameter in each dependent artifact's definition to ensure that tool is properly resoved on the client.
- Loading branch information
Showing
29 changed files
with
1,224 additions
and
620 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.