Skip to content

shfmt pre-commit hook fails on files with spaces in path #102

@robert914

Description

@robert914

The shfmt pre-commit hook fails if the file path contains spaces. The issue is that these lines in: https://github.com/jumanjihouse/pre-commit-hooks/blob/master/pre_commit_hooks/shfmt

readonly cmd="shfmt -w $*"
echo "[RUN] ${cmd}"
${cmd}

should probably instead be something like:

readonly cmd=(shfmt "-w" "$@")
echo "[RUN] ${cmd[@]}"
"${cmd[@]}"

To properly handle spaces in paths. Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions