Skip to content

Don't crash when user uses unmatched local name prefix #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't crash when user uses unmatched local name prefix #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d10372e
Don't crash when user uses unmatched local name prefix
May 28, 2020
13229c1
Merge branch 'master' into fix/dont-crash-when-local-not-found
Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 36 additions & 31 deletions tfstructs/vars.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,22 @@ package tfstructs

import (
"fmt"

"github.com/hashicorp/hcl/v2"
"github.com/hashicorp/hcl/v2/hclsyntax"
"github.com/hashicorp/terraform/addrs"
"github.com/hashicorp/terraform/configs"
"github.com/hashicorp/terraform/lang"
"github.com/juliosueiras/terraform-lsp/hclstructs"
"github.com/juliosueiras/terraform-lsp/helper"

// "github.com/juliosueiras/terraform-lsp/loghelper"
"github.com/sourcegraph/go-lsp"
"github.com/zclconf/go-cty/cty"
"os"
"path/filepath"
"reflect"

"github.com/sourcegraph/go-lsp"
"github.com/zclconf/go-cty/cty"
)

type GetVarAttributeRequest struct {
Expand Down Expand Up @@ -75,42 +78,44 @@ func GetVarAttributeCompletion(request GetVarAttributeRequest) []lsp.CompletionI
}
}

testVal, _ := found.Expr.Value(
&hcl.EvalContext{
// Build Full Tree
Variables: variables,
Functions: scope.Functions(),
},
)

origType := reflect.TypeOf(found.Expr)

if origType == hclstructs.ObjectConsExpr() {
items := found.Expr.(*hclsyntax.ObjectConsExpr).Items
for _, v := range request.Variables[2:] {
for _, l := range items {
if v.(hcl.TraverseAttr).Name == l.KeyExpr.(*hclsyntax.ObjectConsKeyExpr).Wrapped.(*hclsyntax.ScopeTraversalExpr).AsTraversal().RootName() {
origType2 := reflect.TypeOf(l.ValueExpr)

if origType2 == hclstructs.ObjectConsExpr() {
items = l.ValueExpr.(*hclsyntax.ObjectConsExpr).Items
if found != nil {
testVal, _ := found.Expr.Value(
&hcl.EvalContext{
// Build Full Tree
Variables: variables,
Functions: scope.Functions(),
},
)

origType := reflect.TypeOf(found.Expr)

if origType == hclstructs.ObjectConsExpr() {
items := found.Expr.(*hclsyntax.ObjectConsExpr).Items
for _, v := range request.Variables[2:] {
for _, l := range items {
if v.(hcl.TraverseAttr).Name == l.KeyExpr.(*hclsyntax.ObjectConsKeyExpr).Wrapped.(*hclsyntax.ScopeTraversalExpr).AsTraversal().RootName() {
origType2 := reflect.TypeOf(l.ValueExpr)

if origType2 == hclstructs.ObjectConsExpr() {
items = l.ValueExpr.(*hclsyntax.ObjectConsExpr).Items
}
}
}
}
}

for _, v := range items {
origType2 := reflect.TypeOf(v.ValueExpr)
request.Result = append(request.Result, lsp.CompletionItem{
Label: v.KeyExpr.(*hclsyntax.ObjectConsKeyExpr).Wrapped.(*hclsyntax.ScopeTraversalExpr).AsTraversal().RootName(),
Detail: fmt.Sprintf(" %s", hclstructs.GetExprStringType(origType2)),
})
for _, v := range items {
origType2 := reflect.TypeOf(v.ValueExpr)
request.Result = append(request.Result, lsp.CompletionItem{
Label: v.KeyExpr.(*hclsyntax.ObjectConsKeyExpr).Wrapped.(*hclsyntax.ScopeTraversalExpr).AsTraversal().RootName(),
Detail: fmt.Sprintf(" %s", hclstructs.GetExprStringType(origType2)),
})
}
}
}

request.Result = append(request.Result, helper.ParseOtherAttr(request.Variables[2:], testVal.Type(), request.Result)...)
request.Result = append(request.Result, helper.ParseOtherAttr(request.Variables[2:], testVal.Type(), request.Result)...)

return request.Result
return request.Result
}

} else if len(request.Variables) == 1 {
for _, v := range request.Files.Locals {
Expand Down