Fix parsing of query field of RowsQueryEvent #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-k1
reviewed
Jan 24, 2024
| @@ -880,12 +880,11 @@ def __init__(self, from_packet, event_size, table_map, ctl_connection, **kwargs) | |||
| super(RowsQueryLogEvent, self).__init__( | |||
| from_packet, event_size, table_map, ctl_connection, **kwargs | |||
| ) | |||
| self.query_length = self.packet.read_uint8() | |||
| self.query = self.packet.read(self.query_length).decode("utf-8") | |||
| self.packet.advance(1) | |||
There was a problem hiding this comment.
How about delete line#875
|
This also crashes for our MySQL 8.035. Would love to see it merged in. We are having to use: poetry add git+ssh://git@github.com:dongwook-chan/python-mysql-replication.git |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first byte of payload in RowsQueryEvent must be ignored without being used as the length for the following field
query. Yet, the existing code did use this value as length forqueryand fails whenever parsing query longer than 255 characters which is the maximum value that a single byte can hold.I fixed the bug referring to code from msql-server.
Other clients in different languages implement the RowsQueryEvent the way mysql-server does and noted below as references.
Type of Change
Checklist
Tests
Additional Information