Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE & Safari compatibility issue #849

Closed
kennethkawamoto opened this issue Feb 23, 2018 · 1 comment
Closed

IE & Safari compatibility issue #849

kennethkawamoto opened this issue Feb 23, 2018 · 1 comment
Labels
Bug

Comments

@kennethkawamoto
Copy link

kennethkawamoto commented Feb 23, 2018 •
edited
Loading

Your system information

  • VelocityJS version: 2.0.1
  • Browser: Safari 11.0.3 / Edge 16
  • Operating System: macOS 10.13.3 / Windows 10

Checklist

  • Is this an issue with code?: [Yes]
  • Is this an issue with documentation?: [Yes]
  • Have you reproduced this in other browsers?: [Yes]
  • Have you checked for updates?: [Yes]
  • Have you checked for similar open issues?: [Yes]

Please describe your issue in as much detail as possible:

Does not work on IE and has an issue manipulating elements' height on Safari

Steps for reproducing this issue (code):

  1. Create a bare-bones code, e.g. to increase the height of an element
  2. Safari 11.0.3 does nothing (Firefox 58.0.2 and Chrome 64.0.3282.186 on macOS works fine)
  3. Edge 16 on Windows 10 (or any IE) throws "Object doesn't support property or method 'velocity'" error
  4. The Velocity website says "Velocity works everywhere — back to IE8"
  5. An older version of Velocity (I have 1.2.2) works perfectly across the board

JSFiddle example showing issue in action (code):

https://jsfiddle.net/www6g4j3/14/
@Rycochet Rycochet added the Bug label Feb 24, 2018
@Rycochet Rycochet changed the title IE & Safari compatinility issue IE & Safari compatibility issue Feb 24, 2018
@kennethkawamoto
Copy link
Author

Amazing - all good, thank you for your brilliant work! 😃

Rycochet added a commit that referenced this issue Aug 3, 2020
@Rycochet
Fixes and updates in preparation for new sequence code All HTMLElemen…
8a19033 
…t css styles are now set/get via a normalization instead of by fallback code Tweens are now an interface (object) instead of an enum indexed array Normalization function is now cached in tween at animation start for performance and consistency Internal version number is now set directly instead of indirectly

Fixes #849 - SVG attribute initialisation was crashing
Fixes #845 - Inconsistent handling of colour codes, now force rgba()
Fixes #839 - - Possibly mis-identification of lineHeight
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rycochet @kennethkawamoto