Skip to content

Commit

Permalink
Test implementation 2
Browse files Browse the repository at this point in the history
  • Loading branch information
julianpoy committed Oct 28, 2021
1 parent 64af21f commit fecd73d
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 8 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/lint-pr-title-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@ jobs:
- uses: ./
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
validateSingleCommit: true

37 changes: 29 additions & 8 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,37 @@ module.exports = async function run() {
});

if (validateSingleCommit) {
const {data: commits} = await client.pulls.listCommits({
owner,
repo,
pull_number: contextPullRequest.number,
per_page: 2
});
const commits = [];
let nonMergeCommits = [];

if (commits.length === 1) {
for await (const response of client.paginate.iterator(
client.pulls.listCommits,
{
owner,
repo,
pull_number: contextPullRequest.number
}
)) {
commits.push(...response.data);

// GitHub does not count merge commits when deciding whether to use
// the PR title or a commit message for the squash commit message.
nonMergeCommits = commits.filter(
(commit) => !commit.commit.message.startsWith('Merge branch')
);

// We only need two non-merge commits to know that the PR
// title won't be used.
if (nonMergeCommits.length >= 2) break;
}

// If there is only one (non merge) commit present, GitHub will use
// that commit rather than the PR title for the title of a squash
// commit. To make sure a semantic title is used for the squash
// commit, we need to validate the commit title.
if (nonMergeCommits.length === 1) {
try {
await validatePrTitle(commits[0].commit.message, {
await validatePrTitle(nonMergeCommits[0].commit.message, {
types,
scopes,
requireScope,
Expand Down

0 comments on commit fecd73d

Please sign in to comment.