Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add changelog from release notes #530

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Sep 28, 2024

Signed-off-by: Diwank Singh Tomer diwank.singh@gmail.com


Important

Update GitHub Actions workflow to generate changelog from release notes on release event.

  • Workflow Changes:
    • Renames workflow from Changelog CI to Changelog on release in .github/workflows/changelog-ci.yml.
    • Changes trigger from pull_request to release with type published.
  • Actions:
    • Updates actions/checkout from v2 to v4 with fetch-depth: 0 and ref: dev.
    • Replaces saadmk11/changelog-ci@v1.1.2 with rhysd/changelog-from-release/action@v3 to generate changelog from release notes.

This description was created by Ellipsis for c609595. It will automatically update as commits are pushed.

Signed-off-by: Diwank Singh Tomer <diwank.singh@gmail.com>
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c609595 in 10 seconds

More details
  • Looked at 40 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/changelog-ci.yml:16
  • Draft comment:
    The ref: dev parameter may not be appropriate for a release event. Consider using a specific tag or the main branch instead.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is relevant to the change made in the diff, specifically the addition of ref: dev. The suggestion to use a specific tag or main branch instead of dev for a release event seems reasonable, as releases are typically associated with stable code. However, without more context on the branching strategy, it's speculative.
    The comment might be speculative because it assumes a certain branching strategy without evidence. The use of dev could be intentional based on the project's workflow.
    The comment raises a valid point about common practices in release workflows, which often use stable branches or tags. It is worth considering even if the current setup is intentional.
    The comment is relevant to the changes and raises a valid point about common practices in release workflows. It should be kept for the author to consider.

Workflow ID: wflow_cGnGUMhCzhtCFtZm


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit cc8adca into dev Sep 28, 2024
4 of 5 checks passed
@creatorrr creatorrr deleted the f/changelog-release-notes branch September 28, 2024 18:48
Vedantsahai18 pushed a commit that referenced this pull request Sep 28, 2024
Update GitHub Actions workflow to generate changelog from release notes on release event.

  - **Workflow Changes**:
    - Renames workflow from `Changelog CI` to `Changelog on release` in `.github/workflows/changelog-ci.yml`.
    - Changes trigger from `pull_request` to `release` with type `published`.
  - **Actions**:
    - Updates `actions/checkout` from `v2` to `v4` with `fetch-depth: 0` and `ref: dev`.
    - Replaces `saadmk11/changelog-ci@v1.1.2` with `rhysd/changelog-from-release/action@v3` to generate changelog from release notes.
creatorrr added a commit that referenced this pull request Sep 30, 2024
Update GitHub Actions workflow to generate changelog from release notes on release event.

  - **Workflow Changes**:
    - Renames workflow from `Changelog CI` to `Changelog on release` in `.github/workflows/changelog-ci.yml`.
    - Changes trigger from `pull_request` to `release` with type `published`.
  - **Actions**:
    - Updates `actions/checkout` from `v2` to `v4` with `fetch-depth: 0` and `ref: dev`.
    - Replaces `saadmk11/changelog-ci@v1.1.2` with `rhysd/changelog-from-release/action@v3` to generate changelog from release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant