Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add agent tools to completion data before sending to litellm in prompt #498

Merged

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Sep 16, 2024

🚀 This description was created by Ellipsis for commit 06666ee

feat: Add agent tools to completion data and update transition logic

Summary:

Adds agent tools to completion data and updates transition logic across the codebase.

Key points:

  • Behavior: Adds agent tools to completion data in prompt_step.py, updates task token handling in raise_complete_async.py, and refactors transition logic in transition_step.py.
  • Models: Adds task_token to CreateTransitionRequest in openapi_model.py.
  • State Management: Updates valid transitions and statuses in tasks.py.
  • Testing: Adjusts tests in test_execution_workflow.py for new workflow steps.
  • Misc: Notes on .DS_Store files (should be removed).

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to ed3b27a in 30 seconds

More details
  • Looked at 353 lines of code in 14 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. agents-api/agents_api/activities/task_steps/raise_complete_async.py:29
  • Draft comment:
    Debugging print statements should be removed or replaced with proper logging before merging the code.
  • Reason this comment was not posted:
    Marked as duplicate.
2. agents-api/agents_api/routers/tasks/update_execution.py:46
  • Draft comment:
    Debugging print statements should be removed or replaced with proper logging before merging the code.
  • Reason this comment was not posted:
    Marked as duplicate.
3. agents-api/tests/test_execution_workflow.py:482
  • Draft comment:
    Consider reducing the sleep duration to speed up test execution unless the delay is necessary for the test logic.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The sleep duration in tests should be minimized to reduce test execution time unless necessary for the test logic.

Workflow ID: wflow_wYI2Nf85Yx5cyqmd


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

agents-api/agents_api/activities/task_steps/prompt_step.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 06666ee in 17 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/activities/task_steps/prompt_step.py:74
  • Draft comment:
    Consider adding error handling for the litellm.acompletion call to manage potential exceptions and ensure robustness.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is about a potential improvement in error handling for a function call that is part of the changed code. Although the change itself was the removal of print statements, the suggestion for error handling is relevant to the robustness of the code. The comment is actionable and clear, suggesting a specific improvement.
    The comment might be considered speculative since it assumes there could be exceptions without evidence. However, error handling is generally a good practice, especially for asynchronous calls.
    Even though the comment is somewhat speculative, adding error handling is a common practice to improve code robustness, especially for network or I/O operations.
    Keep the comment as it suggests a clear and actionable improvement related to the changed code.

Workflow ID: wflow_qTdOc9PIHfCax7Rc


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@HamadaSalhab HamadaSalhab merged commit 5146369 into dev Sep 16, 2024
3 of 6 checks passed
@HamadaSalhab HamadaSalhab deleted the SCRUM-15-agents-api-Implement-prompt-step-if-tool_calls branch September 16, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants