feat(agents-api): Add route tests #451
Conversation
Signed-off-by: Diwank Tomer <diwank@julep.ai>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to afe3be8 in 30 seconds
More details
- Looked at
1519lines of code in10files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_UFngILdBdb2AIblW
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -32,7 +32,12 @@ | |||
| temporal_task_queue = env.str("TEMPORAL_TASK_QUEUE", default="memory-task-queue") | |||
|
|
|||
| # auth | |||
| api_key: str = env.str("AGENTS_API_KEY") | |||
| _random_generated_key = "".join(str(random.randint(0, 9)) for _ in range(32)) | |||
There was a problem hiding this comment.
Using a randomly generated API key as a fallback is potentially insecure and could lead to unpredictable behavior. Consider requiring the API key to be set explicitly and fail initialization if it's not provided.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on dd52045 in 27 seconds
More details
- Looked at
173lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/tests/test_user_routes.py:1
- Draft comment:
This file seems unrelated to the agents API as described in the PR title and description. Please confirm if this file was intended to be part of this PR. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_af6B2ueAAUsVvuKI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Diwank Tomer <diwank@julep.ai>
There was a problem hiding this comment.
❌ Changes requested. Incremental review on d0b3e6b in 45 seconds
More details
- Looked at
235lines of code in11files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_NiCph8MFML8BsyWa
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -27,4 +27,4 @@ async def create_or_update_agent( | |||
| data=data, | |||
| ) | |||
|
|
|||
| return ResourceCreatedResponse(id=agent.id, created_at=agent.created_at) | |||
| return ResourceCreatedResponse(id=agent.id, created_at=agent.created_at, jobs=[]) | |||
There was a problem hiding this comment.
The jobs field in the ResourceCreatedResponse is always set to an empty list, which might not reflect the actual state of jobs associated with the agent. Consider modifying the response to include actual job data if applicable.
| return ResourceCreatedResponse(id=agent.id, created_at=agent.created_at, jobs=[]) | |
| return ResourceCreatedResponse(id=agent.id, created_at=agent.created_at, jobs=agent.jobs) |
| @@ -20,4 +20,4 @@ async def create_user( | |||
| data=data, | |||
| ) | |||
|
|
|||
| return ResourceCreatedResponse(id=user.id, created_at=user.created_at) | |||
| return ResourceCreatedResponse(id=user.id, created_at=user.created_at, jobs=[]) | |||
There was a problem hiding this comment.
The jobs field in the ResourceCreatedResponse is always set to an empty list, which might not reflect the actual state of jobs associated with the user. Consider modifying the response to include actual job data if applicable.
| return ResourceCreatedResponse(id=user.id, created_at=user.created_at, jobs=[]) | |
| return ResourceCreatedResponse(id=user.id, created_at=user.created_at, jobs=user.jobs) |
| @@ -14,4 +14,5 @@ | |||
| async def delete_user( | |||
| user_id: UUID4, x_developer_id: Annotated[UUID4, Depends(get_developer_id)] | |||
| ) -> ResourceDeletedResponse: | |||
| print(user_id) | |||
There was a problem hiding this comment.
The use of print for logging in production code is not recommended as it can lead to unintentional logging of sensitive information. Consider using a logging framework with appropriate log levels.
whiterabbit1983
merged commit 0ee50d4
into
dev-tasks-disable-routes
Signed-off-by: Diwank Tomer diwank@julep.ai
Summary:
This PR adds comprehensive route tests for agents and users, updates client management, and modifies API key handling for improved test coverage and client management.
Key points:
agents-api/tests.get_cozo_clientinagents_api/clients/cozo.py.agents_api/env.pyto generate a random key if not set.create_agentfunction to includejobsin response.julepclients withfastapi.testclient.TestClientin tests.wardfor test definitions andmake_requestfor HTTP requests.Generated with ❤️ by ellipsis.dev