Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdks/ts): Fixed bugs, updated sdk #390

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix(sdks/ts): Fixed bugs, updated sdk #390

merged 2 commits into from
Jun 6, 2024

Conversation

alt-glitch
Copy link
Contributor

@alt-glitch alt-glitch commented Jun 6, 2024

🚀 This description was created by Ellipsis for commit def7fb2

Summary:

Updated SDK for OpenAPI compatibility and fixed TypeScript SDK bugs.

Key points:

  • Updated openapi_model.py timestamp
  • Bumped TypeScript SDK version in package.json
  • Modified openapi-codegen script in package.json
  • Made userId optional in SessionsManager in session.ts

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to def7fb2 in 1 minute and 0 seconds

More details
  • Looked at 67 lines of code in 3 files
  • Skipped 3 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/ts/src/managers/session.ts:40
  • Draft comment:
    The use of short-circuit evaluation (userId && invariant(...)) to conditionally check the validity of userId only when it is provided is correct and aligns with the optional nature of userId in CreateSessionPayload. This ensures that the UUID validation is skipped when userId is not provided, which is the intended behavior.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the CreateSessionPayload interface makes the userId optional, which is reflected in the SessionsManager.create method. However, the logic to check if userId is a valid UUID is only executed if userId is provided. This is done using a short-circuit evaluation (userId && invariant(...)). This approach is correct and ensures that the UUID validation is only performed if userId is not undefined. The rest of the method constructs the request body and sends it to the API client, handling errors appropriately.

Workflow ID: wflow_8K9V4ZV07VP8C6eZ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr changed the title updated sdk to openapi; fixed ts sdk bugs fix(sdks/ts): Fixed bugs, updated sdk Jun 6, 2024
@creatorrr creatorrr merged commit 970be0d into dev Jun 6, 2024
4 checks passed
@creatorrr creatorrr deleted the f/sdk-fixes branch June 6, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants