-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(cli): Misc fixes #1110
base: dev
Are you sure you want to change the base?
doc(cli): Misc fixes #1110
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to dd510ba in 10 seconds
More details
- Looked at
24
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. documentation/guides/julepcli/introduction.mdx:11
- Draft comment:
Consider providing a reason for removing thepipx
installation method, as it is often recommended for CLI tools to avoid dependency conflicts. - Reason this comment was not posted:
Confidence changes required:50%
The removal of the pipx installation method should be explained or justified.
Workflow ID: wflow_8XYg8M1CfIWsLwLY
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on ff3de67 in 13 seconds
More details
- Looked at
68
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_7ETjp2mxjcJGcqfN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on bbf59c1 in 10 seconds
More details
- Looked at
433
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. scripts/generate_changelog.py:105
- Draft comment:
Theauthor_list
is removed from the content in thepreserve_and_update_changelog
function. If this is unintended, consider adding it back to the content. - Reason this comment was not posted:
Confidence changes required:50%
The changelog generation script has a logical error in thepreserve_and_update_changelog
function. Theauthor_list
is removed from the content, which might be unintended.
Workflow ID: wflow_Qsg5ai5cprttqTCM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
PR Type
Documentation
Description
Removed
pipx
installation command from CLI documentation.Updated example to exclude optional
--source
parameter.Changes walkthrough 📝
introduction.mdx
Simplified CLI installation and sync examples
documentation/guides/julepcli/introduction.mdx
pipx
installation command from installation section.julep sync
example to exclude--source
parameter.Important
Simplified CLI documentation by removing
pipx
installation and updatingjulep sync
example inintroduction.mdx
.pipx
installation command fromintroduction.mdx
.julep sync
example to exclude--source
parameter inintroduction.mdx
.This description was created by for bbf59c1. It will automatically update as commits are pushed.