-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(agents-api): remove jinja templates from PromptStep
and LogStep
#1081
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 3331cf1 in 29 seconds
More details
- Looked at
56
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. agents-api/agents_api/activities/task_steps/log_step.py:21
- Draft comment:
Ensure thatbase_evaluate
can handle all cases previously managed byrender_template
, including any specific variable handling likeskip_vars
. - Reason this comment was not posted:
Confidence changes required:50%
The removal of therender_template
function is appropriate given the context of the changes. However, thebase_evaluate
function should be checked for its ability to handle the same cases asrender_template
.
2. agents-api/agents_api/activities/task_steps/prompt_step.py:77
- Draft comment:
Ensure thatbase_evaluate
can handle all cases previously managed byrender_template
, including any specific variable handling likeskip_vars
. This applies to the changes inlog_step.py
as well. - Reason this comment was not posted:
Confidence changes required:50%
The removal of therender_template
function is appropriate given the context of the changes. However, thebase_evaluate
function should be checked for its ability to handle the same cases asrender_template
.
Workflow ID: wflow_CAeETHtZCOGYrQ1w
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
CI Feedback 🧐(Feedback updated until commit 3331cf1)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
PR Type
Enhancement
Description
Removed usage of
render_template
inLogStep
andPromptStep
.Replaced
render_template
withbase_evaluate
for expression evaluation.Simplified logic for handling prompt expressions in
PromptStep
.Changes walkthrough 📝
log_step.py
Replace `render_template` with `base_evaluate` in `LogStep`
agents-api/agents_api/activities/task_steps/log_step.py
render_template
usage for log evaluation.base_evaluate
for expression evaluation.prompt_step.py
Replace `render_template` with `base_evaluate` in `PromptStep`
agents-api/agents_api/activities/task_steps/prompt_step.py
render_template
usage for prompt evaluation.base_evaluate
for expression handling.Important
Replaces Jinja templates with
base_evaluate
inlog_step()
andprompt_step()
to simplify expression evaluation.base_evaluate
inlog_step()
inlog_step.py
.prompt_step()
inprompt_step.py
.log_step()
: Usesbase_evaluate
to processcontext.current_step.log
.prompt_step()
: Removes template rendering logic for non-evaluated prompts.This description was created by for 3331cf1. It will automatically update as commits are pushed.