error.Is testing checker #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following makes it easier to compare errors. Currently, if we attempt to use satisfies checker, we'll more thank likely endup with a deprecation warning that Is prefix predicate variants from the errors package is being used. The solution is to make a new checker that we can move to, which has the semantics that we want moving forward.
tlm
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
lgtm, thanks for this. I have been using bool checkers with errors.Is up until now but this flows a lot better.
Love ya work @SimonRichardson
hpidcock
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following makes it easier to compare errors. Currently, if we attempt to use satisfies checker, we'll more than likely end up with a deprecation warning that
Isprefix predicate variants from the errors package are being used.The solution is to make a new checker that we can move to, which has the semantics that we want moving forward.
You can use it in the following manner: