Changes to support Mongo 3.6. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't drop the 'admin' database, and we don't actually need to pass `--nohttpinterface`. In 3.6, there is no '--httpinterface' that you could pass, so there is also not its negation. But since it isn't the default, we don't actually ever need to pass it.
|
|
1 similar comment
|
|
|
Pull request is not mergeable. |
jujubot
added a commit
to juju/juju
that referenced
this pull request
Apr 2, 2018
#8553 ## Description of change This brings in a testing package that supports mongo 3.6. This is essentially just bringing in: juju/testing#136 ## QA steps Install mongo 3.6 into /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games and make sure you don't have juju-mongodb3.2 installed. You should then be able to do something like: ``` $ cd state $ go test -check.v ``` Without this patch, testing should fail because of passing commandline parameters to mongo that it no longer supports, etc. ## Documentation changes None. ## Bug reference [lp:1760390](https://bugs.launchpad.net/juju/+bug/1760390)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't drop the 'admin' database, and we don't actually need to pass
--nohttpinterface.In 3.6, there is no
--httpinterfacethat you could pass, so there isalso not its negation. But since it isn't the default, we don't actually
ever need to pass it.
This also brings our dependencies.tsv up to date and removes 'gccgo'
from our 'make check' since we don't really use it anyway.
https://bugs.launchpad.net/juju/+bug/1760390