Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add juju_deployment read action #38

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Conversation

night0wl
Copy link
Contributor

This PR will implement the read action for the juju_deployment resource.

** Known Issue **
The API doesn't seem to be handling the "Channel" information and so we are unable to track that currently. This PR includes a band-aid to ensure we can track other attributes while ignoring the channel.

@night0wl night0wl requested a review from jon-ruckwood June 30, 2022 10:26
Copy link
Contributor

@jon-ruckwood jon-ruckwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few minor comments that should be addressed.

@night0wl night0wl force-pushed the implement-juju-deployment-read branch from 4517a8e to 38ad373 Compare June 30, 2022 13:08
@jon-ruckwood jon-ruckwood self-requested a review June 30, 2022 13:22
@night0wl night0wl force-pushed the implement-juju-deployment-read branch from 38ad373 to 6b46343 Compare June 30, 2022 13:26
@night0wl night0wl merged commit d543fbd into main Jun 30, 2022
@night0wl night0wl deleted the implement-juju-deployment-read branch June 30, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants