Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement juju deployment delete #32

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Conversation

maxflintoff
Copy link
Contributor

This implements the Delete action for juju_deployment.

Note This is known in Juju as destroy rather than delete so the client has a method Destroy that is called by the provider's delete command.

Tests are currently skipped pending read:

=== RUN   TestAcc_ResourceDeployment
    resource_deployment_test.go:20: Step 1/1 error: Error running post-apply refresh: exit status 1
        
        Error: not implemented
        
          with juju_deployment.this,
          on terraform_plugin_test.tf line 6, in resource "juju_deployment" "this":
           6: resource "juju_deployment" "this" {
        
--- FAIL: TestAcc_ResourceDeployment (4.01s)

@maxflintoff maxflintoff requested review from jon-ruckwood and night0wl and removed request for jon-ruckwood June 28, 2022 11:40
Copy link
Contributor

@jon-ruckwood jon-ruckwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maxflintoff maxflintoff merged commit 74dfe37 into main Jun 28, 2022
@maxflintoff maxflintoff deleted the implement-juju-deployment-delete branch June 28, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants