Change series lint from warn to info message (#618)

As a 'warn' the message causes the charm proof to fail which will fail most builds. This patch changes it to 'info'.
juju · Aug 2, 2022 · fe92638 · fe92638
1 parent c70f886
commit fe92638
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/charmtools/charms.py b/charmtools/charms.py
@@ -811,15 +811,17 @@ def validate_series(charm, linter):
 
     The `series` parameter is deprecated because charmcraft ignores it and
     uses `bases` from `charmcraft.yaml`. This function checks if the series
-    is in metadata.yaml and displays a warning message if so.
+    is in metadata.yaml and displays an info message if so. Note that it is not
+    a warning as that causes an error in the charm proof which isn't what is
+    wanted.
 
     :param charm: dict of charm metadata parsed from metadata.yaml
     :param linter: :class:`CharmLinter` object to which info/warning/error
         messages will be written
 
     """
     if 'series' in charm:
-        linter.warn('DEPRECATED: series parameter is ignored by charmcraft,'
+        linter.info('DEPRECATED: series parameter is ignored by charmcraft,'
                     'use bases in charmcraft.yaml')
 
 

diff --git a/tests/test_charm_proof.py b/tests/test_charm_proof.py
@@ -1261,7 +1261,7 @@ def test_series(self):
         linter = Mock()
         charm = {"series": []}
         validate_series(charm, linter)
-        self.assertTrue(linter.warn.called)
+        self.assertTrue(linter.info.called)
 
 
 class TermsValidationTest(TestCase):