Clean-up around adding linux bridges to OVS bridges #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we used to mark only OVS interfaces
1. Fix missing 'ifup' on bionic. 2. Mark the OVS port also when upgrading the charm.
ajkavanagh
reviewed
Apr 14, 2020
ajkavanagh
reviewed
Jul 6, 2020
ajkavanagh
previously approved these changes
Jul 9, 2020
|
As discussed with @thedac we want to be more opinionated here and neither create |
ajkavanagh
approved these changes
Jul 22, 2020
lourot
changed the title
fnordahl
approved these changes
Jul 22, 2020
openstack-mirroring
pushed a commit
to openstack/charm-neutron-gateway
that referenced
this pull request
Aug 27, 2020
This patchset updates the configure_ovs() function in hooks/neutron_utils.py such that ports and bridges in OVS are marked as being managed by this charm. This will allow us to clean up obsolete managed bridges and ports in a later patchset. (On configuration change new ports and bridges might be created and former ones might become obsolete.) This patchset also fully deprecates the 'ext-port' config option such that if both 'data-port' and 'ext-port' config options are set, the unit is blocked. The README and config.yaml are updated to reflect this change. This patchset also fixes and removes a few dead links. Relies on a charm-helpers version containing these patchsets: juju/charm-helpers#443 juju/charm-helpers#447 juju/charm-helpers#449 Related documentation: * Deployment guide / Upgrades / Known issues: https://review.opendev.org/630290 * Release notes: https://review.opendev.org/742660 Change-Id: I8b459135d131e16865de40ff3eae16ea3bc7195e Partial-Bug: #1809190
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Aug 27, 2020
* Update charm-neutron-gateway from branch 'master'
- Mark OVS bridges and ports as managed by charm-neutron-gateway
This patchset updates the configure_ovs() function in
hooks/neutron_utils.py such that ports and bridges in OVS are marked as
being managed by this charm. This will allow us to clean up obsolete
managed bridges and ports in a later patchset. (On configuration change
new ports and bridges might be created and former ones might become
obsolete.)
This patchset also fully deprecates the 'ext-port' config option such
that if both 'data-port' and 'ext-port' config options are set, the unit
is blocked. The README and config.yaml are updated to reflect this
change.
This patchset also fixes and removes a few dead links.
Relies on a charm-helpers version containing these patchsets:
juju/charm-helpers#443
juju/charm-helpers#447
juju/charm-helpers#449
Related documentation:
* Deployment guide / Upgrades / Known issues: https://review.opendev.org/630290
* Release notes: https://review.opendev.org/742660
Change-Id: I8b459135d131e16865de40ff3eae16ea3bc7195e
Partial-Bug: #1809190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans things up around
ifupfor adding a linux bridge to an OVS bridge and handle the fact that this isn't supported anymore.Also useful for marking the corresponding ports as managed by us.