Skip to content

Commit

Permalink
Merge pull request #36 from juicedata/bug/options
Browse files Browse the repository at this point in the history
fix parameter naming compatibility
  • Loading branch information
timfeirg authored Jan 2, 2024
2 parents d745016 + 0f8fed0 commit 27cc37d
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/go.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Go
on:
push:
branches:
branches:
- master

jobs:
Expand Down
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ Modified from https://github.com/vieux/docker-volume-sshfs
``` shell
docker plugin install juicedata/juicefs

# JuiceFS open sourced version
docker volume create -d juicedata/juicefs:latest -o name=$JFS_VOL -o metaurl=$JFS_META_URL -o access-key=$JFS_ACCESSKEY -o secret-key=JFS_SECRETKEY jfsvolume
# JuiceFS Community Edition
docker volume create -d juicedata/juicefs:latest -o name=$JFS_VOL -o metaurl=$JFS_META_URL jfsvolume
docker run -it -v jfsvolume:/opt busybox ls /opt

# JuiceFS hosted version
docker volume create -d juicedata/juicefs:latest -o name=$JFS_VOL -o token=$JFS_TOKEN -o accesskey=$JFS_ACCESSKEY -o secretkey=$JFS_SECRETKEY jfsvolume
# JuiceFS Enterprise Edition
docker volume create -d juicedata/juicefs:latest -o name=$JFS_VOL -o token=$JFS_TOKEN -o access-key=$JFS_ACCESSKEY -o secret-key=$JFS_SECRETKEY jfsvolume
docker run -it -v jfsvolume:/opt busybox ls /opt
```

Expand All @@ -36,7 +36,7 @@ rsync -avz --exclude plugin --exclude .git --exclude .vagrant /vagrant/ $WORKDIR
cd $WORKDIR
make
make enable
docker volume create -d juicedata/juicefs:next -o name=$JFS_VOL -o token=$JFS_TOKEN -o accesskey=$JFS_ACCESSKEY -o secretkey=$JFS_SECRETKEY jfsvolume
docker volume create -d juicedata/juicefs:next -o name=$JFS_VOL -o token=$JFS_TOKEN -o access-key=$JFS_ACCESSKEY -o secret-key=$JFS_SECRETKEY jfsvolume
docker run -it -v jfsvolume:/opt busybox ls /opt
```

Expand All @@ -49,7 +49,7 @@ Use `docker service` to deploy to Docker swarm
``` shell
docker service create --name nginx --mount \
type=volume,volume-driver=juicedata/juicefs,source=jfsvolume,destination=/jfs,\
volume-opt=name=$JFS_VOL,volume-opt=token=$JFS_TOKEN,volume-opt=accesskey=$JFS_ACCESSKEY,volume-opt=secretkey=$JFS_SECRETKEY nginx:alpine
volume-opt=name=$JFS_VOL,volume-opt=token=$JFS_TOKEN,volume-opt=access-key=$JFS_ACCESSKEY,volume-opt=secret-key=$JFS_SECRETKEY nginx:alpine
```

Scale up
Expand Down
4 changes: 4 additions & 0 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,14 @@ func eeMount(v *jfsVolume) error {
"token",
"accesskey",
"accesskey2",
"access-key",
"access-key2",
"bucket",
"bucket2",
"secretkey",
"secretkey2",
"secret-key",
"secret-key2",
"passphrase",
}
for _, authOption := range authOptions {
Expand Down

0 comments on commit 27cc37d

Please sign in to comment.