Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NonZeroU8, NonZeroU16, NonZeroU32, and NonZeroU64 #1334

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for NonZeroU8, NonZeroU16, NonZeroU32, and NonZeroU64 #1334

wants to merge 1 commit into from

Conversation

mcronce
Copy link

@mcronce mcronce commented Mar 7, 2025

These output integers matching their primitive counterparts, but with minimum set to 1 instead of 0

@mcronce
Copy link
Author

mcronce commented Mar 7, 2025

Realized I'm incorrectly producing "format": "int32" for NonZeroU8 and NonZeroU16 when non_strict_integers is enabled; need to fix that before this is ready

@mcronce mcronce marked this pull request as draft March 7, 2025 22:49
@mcronce mcronce marked this pull request as ready for review March 7, 2025 23:04
@mcronce
Copy link
Author

mcronce commented Mar 7, 2025

OK, that wasn't the problem. Fixed up the issues...testing still fails with --features=non_strict_integers, but the failures I'm seeing existed prior to my commit. I matched the new test cases with their primitive counterparts because I assume the expected output for the primitives is what's desired. I can change them if that's incorrect, and take a whack at fixing the failing test cases if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcronce