Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/csv export #1

Merged
merged 4 commits into from
Sep 15, 2020
Merged

Feature/csv export #1

merged 4 commits into from
Sep 15, 2020

Conversation

afk0901
Copy link

@afk0901 afk0901 commented Jul 21, 2020

Feature for exporting a CSV file from Gecko by adding a speaker id, speaker name to the labels. Includes some validation because to be able to export the CSV file, id and name are both needed.

@judyfong
Copy link
Owner

First off, sorry for the slow response. I didn't see it until now.
It looks good. There was only a minor error where if you load in an srt file and want to save it as an rttm file you couldn't because region.data.speaker was undefined and couldn't be split. I've fixed that since I don't expect you to now that the summer is over. This workflow is out of scope so it's understandable that it wasn't tested.
Good job and thanks!

@judyfong judyfong merged commit e382a77 into judyfong:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants