BusConfiguration assumes that nsqd is running locally on port 4151

[jmreynolds]

BusConfiguration, in line 331, makes the assumption that nsqd is running locally on port 4151.

I have a fix, that I'm going to do a PR for - this is mostly just a place-holder to remind myself to do this over the weekend.

Unless @judwhite has already resolved it, in which case I'll not bother. Thanks!

[jmreynolds]

Per our conversation on Slack yesterday, I brought Pull Request #83 into my branch, and I'll use that as my point of reference. I'm going to add a unit test or two around the stuff I added in BusConfiguration (really only a couple lines of changes), then I'll submit. Goal is to have it in this weekend.

[judwhite]

@jmreynolds Nice find. Copying my commit comment here.

There's a bit of overlap here between nsqdTcpAddress and nsqdPublisher. If you specify your own publisher the nsqdTcpAddress is ignored, which is probably obvious. Allowing you to provide your own INsqdPublisher was meant to address using an address other than 127.0.0.1:4150 or let you use an HTTP publisher (or something custom) in the bus. Where this falls down is in preCreateTopics, which is arguably not the bus's responsibility and could be removed.

I think this can be solved either through clear documentation or by removing preCreateTopics, possibly offering this functionality somewhere else in the library. BusConfiguration and BusService are candidates for a v1.0 refactor, there are some things about the design I think could be improved.