refactor(delphi): Remove legacy poller/system architecture and dead code

.github/workflows/python-ci.yml

@@ -2,9 +2,15 @@ name: Delphi Python Tests
 
 on:
   push:
-    branches: [ edge, stable ]
+    branches: &branches [ edge, stable ]
+    paths: &paths
+      - 'delphi/**/*.py'
+      - 'delphi/requirements*.txt'
+      - 'delphi/Dockerfile'
+      - '.github/workflows/python-ci.yml'
   pull_request:
-    branches: [ edge, stable ]
+    branches: *branches
+    paths: *paths
 
 jobs:
   test:
@@ -70,6 +76,7 @@ jobs:
         docker compose -f docker-compose.test.yml cp delphi/generate_coverage_md.py delphi:/app/generate_coverage_md.py
         echo "Copying script to be tested into container..."
         docker compose -f docker-compose.test.yml cp delphi/polismath/run_math_pipeline.py delphi:/app/run_math_pipeline.py
+        docker compose -f docker-compose.test.yml cp delphi/umap_narrative delphi:/app/umap_narrative
 
         echo "Running tests and generating coverage report..."
         docker compose \
@@ -90,7 +97,7 @@ jobs:
             python create_dynamodb_tables.py --region us-east-1; \
             echo '--- Running Pytest ---'; \
             export PYTHONPATH=\$PYTHONPATH:/app; \
-            pytest --cov=polismath --cov=run_math_pipeline --cov-report=xml:/app/coverage.xml /app/tests --ignore=/app/tests/test_pakistan_conversation.py
+            pytest --cov=polismath --cov=run_math_pipeline --cov=./umap_narrative --cov-report=xml:/app/coverage.xml /app/tests --ignore=/app/tests/test_pakistan_conversation.py
             echo '--- Generating Coverage Comment Text ---'; \
             python /app/generate_coverage_md.py > /app/coverage-comment.md \
           "
@@ -100,24 +107,66 @@ jobs:
       run: |
         echo "Copying coverage-comment.md from delphi container..."
         docker compose -f docker-compose.test.yml cp delphi:/app/coverage-comment.md .
+        echo "=== Coverage Report ==="
+        cat coverage-comment.md
 
-    - name: 8. Post Coverage Comment
+    - name: 8. Upload Coverage Report
+      if: success()
+      uses: actions/upload-artifact@v4
+      with:
+        name: coverage-report
+        path: coverage-comment.md
+
+    - name: 9. Post Coverage Comment
       if: success() && github.event_name == 'pull_request'
       uses: actions/github-script@v6
       with:
         github-token: ${{ secrets.GITHUB_TOKEN }}
         script: |
           const fs = require('fs');
           const commentBody = fs.readFileSync('coverage-comment.md', 'utf8');
-
-          await github.rest.issues.createComment({
-            issue_number: context.issue.number,
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            body: "## Coverage Report\n\n" + commentBody
-          });
-
-    - name: 9. Show service logs on failure
+          const marker = '<!-- delphi-coverage-report -->';
+          const body = `${marker}\n## Delphi Coverage Report\n\n${commentBody}`;
+
+          try {
+            // Find existing coverage comment
+            const { data: comments } = await github.rest.issues.listComments({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+            });
+
+            const existingComment = comments.find(c => c.body.includes(marker));
+
+            if (existingComment) {
+              // Delete existing comment so new one appears after latest commit
+              await github.rest.issues.deleteComment({
+                comment_id: existingComment.id,
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+              });
+              console.log('Existing coverage comment deleted.');
+            }
+
+            // Always create a new comment
+            await github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body: body
+            });
+            console.log('Coverage comment posted successfully.');
+          } catch (error) {
+            if (error.status === 403) {
+              console.log('Note: Could not post coverage comment to PR.');
+              console.log('This is expected for PRs from forks due to GitHub token permissions.');
+              console.log('Coverage report is available in the workflow logs (step 7) and as a downloadable artifact (step 8).');
+            } else {
+              console.log(`Unexpected error posting comment: ${error.message}`);
+            }
+          }
+
+    - name: 10. Show service logs on failure
       if: failure()
       run: |
         echo "=== Delphi service logs ==="
@@ -127,7 +176,7 @@ jobs:
         echo "=== DynamoDB service logs ==="
         docker compose -f docker-compose.test.yml logs dynamodb || true
 
-    - name: 10. Clean up services
+    - name: 11. Clean up services
       if: always()
       run: |
         echo "Cleaning up services..."

.vscode/launch.json

@@ -25,6 +25,40 @@
         "package": "${workspaceFolder}/server/package.json",
         "localRoot": "${workspaceFolder}/server"
       }
+    },
+    {
+      "name": "Python: Debug Regression Tests",
+      "type": "debugpy",
+      "request": "launch",
+      "module": "pytest",
+      "args": [
+        "regression_tests",
+        "-v"
+      ],
+      "console": "integratedTerminal",
+      "justMyCode": false,
+      "cwd": "${workspaceFolder}/delphi",
+      "python": "${workspaceFolder}/.venv/bin/python",
+      "env": {
+        "PYTHONPATH": "${workspaceFolder}/delphi"
+      }
+    },
+    {
+      "name": "Python: Debug Current Test File",
+      "type": "debugpy",
+      "request": "launch",
+      "module": "pytest",
+      "args": [
+        "${relativeFile}",
+        "-v"
+      ],
+      "console": "integratedTerminal",
+      "justMyCode": false,
+      "cwd": "${workspaceFolder}/delphi",
+      "python": "${workspaceFolder}/.venv/bin/python",
+      "env": {
+        "PYTHONPATH": "${workspaceFolder}/delphi"
+      }
     }
   ]
 }

.vscode/tasks.json

@@ -36,7 +36,51 @@
       "node": {
         "package": "${workspaceFolder}/server/package.json",
         "enableDebugging": true
-      }
+        }
+    },
+    {
+        "label": "Run Regression Tests",
+        "type": "shell",
+        "command": "${workspaceFolder}/.venv/bin/python",
+        "args": [
+            "-m",
+            "pytest",
+            "regression_tests",
+            "-v"
+        ],
+        "options": {
+            "cwd": "${workspaceFolder}/delphi"
+        },
+        "group": {
+            "kind": "build"
+        },
+        "presentation": {
+            "reveal": "always",
+            "panel": "new"
+        },
+        "problemMatcher": []
+    },
+    {
+        "label": "Run Regression Tests (Parallel)",
+        "type": "shell",
+        "command": "${workspaceFolder}/.venv/bin/python",
+        "args": [
+            "-m",
+            "pytest",
+            "regression_tests",
+            "-v",
+            "-n",
+            "auto"
+        ],
+        "options": {
+            "cwd": "${workspaceFolder}/delphi"
+        },
+        "group": "build",
+        "presentation": {
+            "reveal": "always",
+            "panel": "new"
+        },
+        "problemMatcher": []
     }
   ]
 }