Skip to content

500 on automated security tests with null char in strings #437

Open
@Amoki

Description

@Amoki

Some customers run automated tests on our services trying basic SQL injections and known OIDC implementation errors.

A few hundred requests contain null chars (\x00) in client_id, leading to a DatabaseError: PostgreSQL text fields cannot contain NUL (0x00) bytes. It leads to a lot of 500 error responses.

I want to open a PR but I'm asking for your advice first:
Should I sanitize params strings here https://github.com/juanifioren/django-oidc-provider/blob/master/oidc_provider/lib/endpoints/authorize.py#L85 ?

Or do you see it somewhere else?

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions