feat: set up npm publish for standalone server executable
#411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only thing I didn't do is change the `package.json` `name`, since that would also change the VSCode extension name. But `solidity` is taken on NPM, so you'll need to temporarily change the name each time you run `npm publish` and then change it back. Publish to NPM: `npm publish` Users: ``` npm install -g @juanfranblano/vscode-solidity-server vscode-solidity-server --stdio ``` This PR does two things to make this possible: - adds "files" and "prePublishOnly" to `package.json` to use `tsup` - updates `server.ts` to read the default config from `package.json` so that even if the client doesn't send a config, they'll still get the default behavior. This is because if the non-VSCode client has to keep manually copying the client config from `package.json`, it's hard to keep it up-to-date.
|
Wow thanks this is great! |
|
@juanfranblanco did you want to set up an npm account? or I can publish an independent version |
|
@llllvvuu is there any guide available to set this up in Neovim? |
I forked nvim-lspconfig: llllvvuu/nvim-lspconfig@08664bf I will make that a PR if/when the npm release becomes available from @juanfranblanco (#429) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #282
The only thing I didn't do is change the
package.jsonname, since that would also change the VSCode extension name. Butsolidityis taken on NPM, so you'll need to temporarily change the name each time you runnpm publishand then change it back. This can be done in a GitHub Action.Publish to NPM:
npm publish.Users:
The changes:
package.jsonto usetsupserver.tsto read the default config frompackage.jsonso that even if the client doesn't send a config, they'll still get the default behavior. This is because if the non-VSCode client has to keep manually copying the client config frompackage.json, it's hard to keep it up-to-date.server.tsis just me moving theonDidChangeConfigurationlogic into a separate function so that it can be run in bothonInitializeandonDidChangeConfiguration.