Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forced Tags with legitimate tagOwners #602

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Fix forced Tags with legitimate tagOwners #602

merged 1 commit into from
Jun 2, 2022

Conversation

iSchluff
Copy link
Contributor

@iSchluff iSchluff commented Jun 1, 2022 •
edited
Loading

Basically always check whether a tag is forced instead of just on tagOwners failure. Also replace loops with contains.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

@iSchluff
Fix forced Tags with legitimate tagOwners
6dccfee 
Also replace loops contains
@kradalby
Copy link
Collaborator

kradalby commented Jun 1, 2022

@restanrm could you also have a look?

@iSchluff
Copy link
Contributor Author

iSchluff commented Jun 1, 2022

Just noticed that without this PR forcedTags can't be used at all because to have a valid acl containing tags they need to be listed under tagOwners.

Maybe with forcedTags that requirement could be relaxed?

restanrm
restanrm reviewed Jun 1, 2022
View reviewed changes
Copy link
Contributor

@restanrm restanrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you !

@kradalby kradalby merged commit b1ba7ba into juanfont:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@restanrm restanrm restanrm left review comments

@kradalby kradalby kradalby approved these changes

@juanfont juanfont Awaiting requested review from juanfont juanfont is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iSchluff @kradalby @restanrm