Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove necessary buf installation #557

Merged
merged 2 commits into from
Apr 22, 2022
Merged

remove necessary buf installation #557

merged 2 commits into from
Apr 22, 2022

Conversation

mpldr
Copy link
Contributor

@mpldr mpldr commented Apr 21, 2022

This commit adds buf as a regular dependency and go running it instead
of requiring installing buf to one's own GOBIN.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

This also has the added advantage that every user is always using the same version.

This commit adds buf as a regular dependency and go running it instead
of requiring installing buf to one's own GOBIN.
@mpldr mpldr requested review from juanfont and kradalby as code owners April 21, 2022 18:24
@kradalby
Copy link
Collaborator

I was slightly mixed on this, but changed my mind when I realise this is what I set up for the actual gRPC plugins.

Unless working on API stuff, it isnt needed for building, but might as well have it available.

I am happy to add this now, but I will consider it obsoleted by #482, which defines the whole build env in a stricter manner.

@kradalby kradalby merged commit 970dea5 into juanfont:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants