feat: Add magicdns_peer_aaaa config option
#2724
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a new boolean config option, `magicdns_peer_aaaa`. When enabled, it adds the `magicdns-aaaa` node attribute to devices with a valid overlay IPv6 address. This attribute allows MagicDNS to resolve AAAA (IPv6) DNS queries for other nodes in the tailnet. This is a new opt-in feature for Tailscale 1.84+ and is implemented as a global config option, similar to `RandomizeClientPort`, since support for configuring node attributes via policies is not yet available.
mindolo
force-pushed
the
magicdns-aaaa-attr
branch
from
da1b760 to
6ea0656
Compare
Author
|
I opened this draft PR to ask for help as I was stuck on the integration tests, but as soon as I did, it all clicked and I was able to fix the test and get it to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new boolean config option,
magicdns_peer_aaaa.When enabled, it adds the
magicdns-aaaanode attribute to devices with a valid overlay IPv6 address.This attribute allows MagicDNS to resolve AAAA (IPv6) DNS queries for other nodes in the tailnet.
This is a new opt-in feature for Tailscale 1.84+ and is implemented as a global config option, similar to
RandomizeClientPort, since support for configuring node attributes via policies is not yet available.Fixes #2723