Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove routes without a node_id #2386

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Remove routes without a node_id #2386

merged 1 commit into from
Jan 30, 2025

Conversation

nblock
Copy link
Collaborator

@nblock nblock commented Jan 28, 2025

The routes table has a NOT NULL constraint on node_id.

Fixes: #2376

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

kradalby
kradalby approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@kradalby kradalby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add a changelog after #2388

@nblock
Remove routes without a node_id
984ee84 
The routes table has a NOT NULL constraint on node_id.

Fixes: juanfont#2376
@nblock nblock added this to the v0.24.2 milestone Jan 30, 2025
@kradalby kradalby merged commit f44b1d3 into juanfont:main Jan 30, 2025
137 checks passed
@nblock nblock deleted the nodeid-null branch January 30, 2025 13:58
kradalby pushed a commit that referenced this pull request Jan 30, 2025
@nblock @kradalby
Remove routes without a node_id (#2386)
341a3d3 
The routes table has a NOT NULL constraint on node_id.

Fixes: #2376
socoldkiller pushed a commit to socoldkiller/headscale that referenced this pull request Jan 30, 2025
@nblock @socoldkiller
Remove routes without a node_id (juanfont#2386)
2a5e2fa 
The routes table has a NOT NULL constraint on node_id.

Fixes: juanfont#2376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kradalby kradalby kradalby approved these changes

@juanfont juanfont Awaiting requested review from juanfont juanfont is a code owner

@ohdearaugustin ohdearaugustin Awaiting requested review from ohdearaugustin ohdearaugustin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.24.2
Development

Successfully merging this pull request may close these issues.

Migration failed
2 participants
@nblock @kradalby