Rewrite authentication flow #2374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
force-pushed
the
kradalby/no-more-any-key
branch
3 times, most recently
from
5ffe036 to
dd7929b
Compare
kradalby
force-pushed
the
kradalby/no-more-any-key
branch
from
aee34a8 to
b12df05
Compare
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Fixes juanfont#1310 Fixes juanfont#2327 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
kradalby/no-more-any-key
branch
from
b12df05 to
cbd1c00
Compare
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
kradalby/no-more-any-key
branch
from
375ddc2 to
62f8fd2
Compare
kradalby
requested review from
ohdearaugustin,
nblock and
juanfont
as code owners
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes a look at the authentication flow with fresh eyes, and it more or less deletes all of it and simplifies it.
I think we made a lot of "guesses" for what needs to happen in the early they so there was a lot of unnecessary conditional paths and code that was really hard to follow.
This code rearranges it so it is a relatively simple "directed graph" so it should be easier to follow.
The motivation for this was inconsistent handling and bugs causing #2327 and #1310, as well as different behaviour logging in and out with different auth methods.
Fixes #2327
Fixes #1310
Probably also:
Fixes #1522