Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated proposals #2104

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Remove outdated proposals #2104

merged 1 commit into from
Sep 5, 2024

Conversation

nblock
Copy link
Collaborator

@nblock nblock commented Sep 5, 2024

Fixes: #2101

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Summary by CodeRabbit

  • Documentation
    • Updated the navigation structure by removing the "Proposals" section, streamlining available documentation links for users.

Copy link
Contributor

coderabbitai bot commented Sep 5, 2024

Walkthrough

The changes involve the removal of the "Proposals" section from the mkdocs.yml configuration file, which included two entries: "ACLs" and "Better routing." This adjustment indicates a shift away from these proposals, reflecting their diminished relevance or resolution elsewhere in the documentation.

Changes

Files Change Summary
mkdocs.yml Removed the "Proposals" section and its entries: ACLs and Better routing.

Assessment against linked issues

Objective Addressed Explanation
Convert proposals to issues or delete them (#[2101])

Poem

In the meadow, bright and clear,
Proposals gone, we cheer, oh dear!
With hops and skips, we dance around,
New paths to take, new joys abound!
A lighter load, we bound away,
Celebrating change, hip-hip-hooray! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e43d6a0 and 3f3c72f.

Files selected for processing (1)
  • mkdocs.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • mkdocs.yml

@kradalby kradalby enabled auto-merge (squash) September 5, 2024 11:23
@kradalby kradalby merged commit 1c34101 into juanfont:main Sep 5, 2024
115 checks passed
@nblock nblock deleted the proposals branch September 5, 2024 13:16
@coderabbitai coderabbitai bot mentioned this pull request Sep 9, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Convert proposals to issues or delete them
2 participants