Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gh workflow actions #1809

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

vdovhanych
Copy link
Contributor

@vdovhanych vdovhanych commented Mar 3, 2024

What is changed by this PR:

  • Updates the various actions used for the projects workflows
  • Changes the tj-actions/changed-files to better maintained action dorny/paths-filter usage is basically the same and from what i tested its working as expected.
    • This also allows a better granularity for the file filters with more options to conditionally run what is needed.
       - name: Get changed files
         id: changed-files
         uses: dorny/paths-filter@v3
         with:
           filters: |
             yaml-files:
               - 'config-example.yaml'
             go-files
               - '**/*.go'
             nix-files
               - '*.nix'
    and the you can use it with steps.changed-files.outputs.<filter-name> == 'true' to run it only if the files from that filter were changed.
  • Small adjustments to file formatting

As next step i would like to introduce some naming conventions for the action files, workflow names and so on. But this is more upt to you guys if youd like that change.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

@vdovhanych
Copy link
Contributor Author

Hello @kradalby, could you take a look and trigger the runs to see if everything is fine?

@kradalby
Copy link
Collaborator

Sorry completely missed this, I will take a look later today or tomorrow

@kradalby
Copy link
Collaborator

As next step i would like to introduce some naming conventions for the action files, workflow names and so on. But this is more upt to you guys if youd like that change.

Happy to receive a proposal!

@kradalby kradalby merged commit ef26f58 into juanfont:main Mar 13, 2024
98 checks passed
@ohdearaugustin ohdearaugustin mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants