implement selfupdate and pass expiry #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
force-pushed
the
propogate-expiry
branch
from
91a158a to
2067f55
Compare
Currently we support informing nodes upon change, but do not have a mechanism for updating the node from control and down. This commits add a SelfUpdate state change, which allows this. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
propogate-expiry
branch
from
2067f55 to
d9a3891
Compare
This commit makes sure node expiry is propagated to the nodes immediatly when a node expiry even occurs and verifies this with integration tests. In addition, it removes old logic for filtering out expired nodes from the netmap, this is not how Tailscale SaaS does it, and we should follow the same approach. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
propogate-expiry
branch
from
6c3a868 to
623c6aa
Compare
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
propogate-expiry
branch
from
f32dce8 to
a77a229
Compare
juanfont
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we support informing nodes upon change, but do not have a mechanism for updating the node from control and down.
This commits add a SelfUpdate state change and it is used to inform a node if it keys has been expired control side.
This PR makes 1.36 the last supported version as it exposes keyexpiry information.
fixes #1645