Skip to content

Commit

Permalink
linting again
Browse files Browse the repository at this point in the history
  • Loading branch information
ImpostorKeanu committed Jan 31, 2022
1 parent 9de5c7f commit da5250e
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 36 deletions.
39 changes: 18 additions & 21 deletions app.go
Original file line number Diff line number Diff line change
Expand Up @@ -657,11 +657,10 @@ func (h *Headscale) getTLSSettings() (*tls.Config, error) {
log.Warn().Msg("Listening with TLS but ServerURL does not start with https://")
}

clientAuthMode, err := h.GetClientAuthMode()

if err != nil {
return nil, err
}
clientAuthMode, err := h.GetClientAuthMode()
if err != nil {
return nil, err
}

log.Info().Msg(fmt.Sprintf(
"Client authentication (mTLS) is \"%s\". See the docs to learn about configuring this setting.",
Expand All @@ -683,22 +682,20 @@ func (h *Headscale) getTLSSettings() (*tls.Config, error) {
// Look up the TLS constant relative to user-supplied TLS client
// authentication mode.
func (h *Headscale) GetClientAuthMode() (tls.ClientAuthType, error) {

switch h.cfg.TLSClientAuthMode {
case DisabledClientAuth:
// Client cert is _not_ required.
return tls.NoClientCert, nil
case RelaxedClientAuth:
// Client cert required, but _not verified_.
return tls.RequireAnyClientCert, nil
case EnforcedClientAuth:
// Client cert is _required and verified_.
return tls.RequireAndVerifyClientCert, nil
default:
return tls.NoClientCert, Error("Invalid tls_client_auth_mode provided: " +
h.cfg.TLSClientAuthMode)
}

switch h.cfg.TLSClientAuthMode {
case DisabledClientAuth:
// Client cert is _not_ required.
return tls.NoClientCert, nil
case RelaxedClientAuth:
// Client cert required, but _not verified_.
return tls.RequireAnyClientCert, nil
case EnforcedClientAuth:
// Client cert is _required and verified_.
return tls.RequireAndVerifyClientCert, nil
default:
return tls.NoClientCert, Error("Invalid tls_client_auth_mode provided: " +
h.cfg.TLSClientAuthMode)
}
}

func (h *Headscale) setLastStateChangeToNow(namespace string) {
Expand Down
27 changes: 12 additions & 15 deletions app_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,22 +66,19 @@ func (s *Suite) ResetDB(c *check.C) {

// Enusre an error is returned when an invalid auth mode
// is supplied.
func (s *Suite) TestInvalidClientAuthMode(c *check.C){
app.cfg.TLSClientAuthMode = "invalid"
_, err := app.GetClientAuthMode()
c.Assert(err, check.NotNil)
func (s *Suite) TestInvalidClientAuthMode(c *check.C) {
app.cfg.TLSClientAuthMode = "invalid"
_, err := app.GetClientAuthMode()
c.Assert(err, check.NotNil)
}

// Ensure that all client auth modes return a nil error
func (s *Suite) TestAuthModes(c *check.C){

var modes = []string{"disabled", "relaxed", "enforced"}

for _, v := range modes {
app.cfg.TLSClientAuthMode = v
_, err := app.GetClientAuthMode()
c.Assert(err, check.IsNil)
}
// Ensure that all client auth modes return a nil error.
func (s *Suite) TestAuthModes(c *check.C) {
modes := []string{"disabled", "relaxed", "enforced"}

for _, v := range modes {
app.cfg.TLSClientAuthMode = v
_, err := app.GetClientAuthMode()
c.Assert(err, check.IsNil)
}
}

0 comments on commit da5250e

Please sign in to comment.