Bubble error up to user for rename

juanfont · Apr 24, 2022 · 62808cb · 62808cb
1 parent 14994cb
commit 62808cb
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/grpcv1.go b/grpcv1.go
@@ -215,7 +215,7 @@ func (api headscaleV1APIServer) ExpireMachine(
 	)
 
 	log.Trace().
-		Str("machine", machine.Name).
+		Str("machine", machine.Hostname).
 		Time("expiry", *machine.Expiry).
 		Msg("machine expired")
 
@@ -231,13 +231,16 @@ func (api headscaleV1APIServer) RenameMachine(
 		return nil, err
 	}
 
-	api.h.RenameMachine(
+	err = api.h.RenameMachine(
 		machine,
 		request.GetNewName(),
 	)
+	if err != nil {
+		return nil, err
+	}
 
 	log.Trace().
-		Str("machine", machine.Name).
+		Str("machine", machine.Hostname).
 		Time("expiry", *machine.Expiry).
 		Msg("machine expired")
 
@@ -393,7 +396,7 @@ func (api headscaleV1APIServer) DebugCreateMachine(
 
 	newMachine := Machine{
 		MachineKey: request.GetKey(),
-		Name:       request.GetName(),
+		Hostname:   request.GetName(),
 		Namespace:  *namespace,
 
 		Expiry:               &time.Time{},