chore: replace eslint-config-semistandard with eslint-config-standard (…

…nodejs#4586)

eslint-config-semistandard hasn't been published in a year as of this
writing and does not install with the version of eslint that we use
without --force or --legacy-peer-deps.

Replace it with the up-to-date eslint-config-standard, and change the
semi rule in .eslintrc to have the same impact. This also disables
two (new?) rules that now flag errors in our markdown files. These
can be investigated later or not. It also makes a small change to
release-post.js so it complies with a rule about using object
shorthand when possible.

Fixes: nodejs#4585

.eslintrc

@@ -1,7 +1,7 @@
 {
   "extends": [
     "eslint:recommended",
-    "semistandard",
+    "standard",
     "prettier"
   ],
   "plugins": [
@@ -29,6 +29,8 @@
       },
       "rules": {
         "eqeqeq": "off",
+        "n/no-deprecated-api": "off",
+        "n/handle-callback-err": "off",
         "no-const-assign": "off",
         "no-undef": "off",
         "no-unused-expressions": "off",
@@ -42,7 +44,8 @@
             "singleQuote": true,
             "trailingComma": "none"
           }
-        ]
+        ],
+        "semi": ["error", "always"]
       }
     }
   ]

package.json

@@ -60,7 +60,7 @@
     "cross-env": "^7.0.3",
     "eslint": "^8.14.0",
     "eslint-config-prettier": "^8.5.0",
-    "eslint-config-semistandard": "^16.0.0",
+    "eslint-config-standard": "^17.0.0",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-markdown": "^2.2.1",
     "eslint-plugin-node": "^11.1.0",

scripts/release-post.js

@@ -169,7 +169,7 @@ function findAuthorLogin(version, section) {
 
 function urlOrComingSoon(binary) {
   const url = binary.url.replace('nodejs.org', 'direct.nodejs.org');
-  return sendRequest({ url: url, method: 'HEAD' }).then(
+  return sendRequest({ url, method: 'HEAD' }).then(
     () => `${binary.title}: ${binary.url}`,
     () => {
       console.log(`\x1B[32m "${binary.title}" is Coming soon...\x1B[39m`);