Skip to content

Update to JupyterLab 2.0 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/blank.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v1
uses: actions/checkout@v2
- name: Install node
uses: actions/setup-node@v1
with:
Expand All @@ -23,6 +23,7 @@ jobs:
run: python -m pip install jupyterlab
- name: Run tests
run: |
npm install
npm run build
npm run test
jlpm && jlpm run build
jlpm run test
- name: Browser check
run: python -m jupyterlab.browser_check
12 changes: 6 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ conda create -c conda-forge -n jupyterlab-python-bytecode yarn nodejs jupyterlab
conda activate jupyterlab-python-code

# Install the dependencies
npm install
jlpm

# Build the extension
npm run build
jlpm run build

# Link the JupyterLab extension
jupyter labextension link .
Expand All @@ -30,7 +30,7 @@ To double check the extension has been linked correctly, run:
The command should return something similar to the following:

```
JupyterLab v0.34.10
JupyterLab v2.0.1
Known labextensions:
app dir: /path/to/miniconda/envs/jupyterlab-python-bytecode/share/jupyter/lab
jupyterlab-python-bytecode v0.1.0 enabled OK*
Expand All @@ -49,7 +49,7 @@ To rebuild the package and the JupyterLab app:

```bash
# Build the extension
npm run build
jlpm run build

# Rebuild JupyterLab
jupyter lab build
Expand All @@ -62,11 +62,11 @@ It is also possible to use the `watch` script to automatically rebuild the exten
jupyter lab --watch

# Start the watch script
npm run watch
jlpm run watch
```

## Tests

To run the tests:

`npm run test`
`jlpm run test`
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ Try the extension in your browser with Binder:

## Prerequisites

- JupyterLab 1.0
- `ipykernel`
- JupyterLab 1.0+
- `ipykernel` or `xeus-python`

To install JupyterLab:

Expand Down
Loading