Skip to content

Conversation

@kswia
Copy link

@kswia kswia commented Oct 25, 2013

Hi,

I modified invoke method to pass xml file instead of single parameters to wsman command. I found that this is the only way to pass multiple parameters with the same key, eg. VDPropNameArray and VDPropValueArray pairs or PDArray. With this modification I can pass dict with key PDArray and value as list: ['Disk.Bay.12:Enclosure.Internal.0-1:RAID.Integrated.1-1', 'Disk.Bay.13:Enclosure.Internal.0-1:RAID.Integrated.1-1']
I hope you'll find it useful.

Kamil

@kswia
Copy link
Author

kswia commented Oct 25, 2013

I closed #4 and I created new one. I had to correct one mistake. Sorry for the mess and 3 commits.

That functionality should already be there. If the argument is a dictionary it's used as a dictionary of argument. If its a string, it's treated as a path to an XML document with arguments.

Almost. With my patch there is no need to create xml file externally. I thought this will be more elegant solution to take care of xml file internally. If you think this is not necessary - you can close this pull request. :)

Kamil

@jtallieu
Copy link
Owner

Awesome. I like it. I have not had a chance to check it out but I understand. This is good.

Sent from my iPhone

On Oct 25, 2013, at 7:29 AM, Kamil Swiatkowski notifications@github.com wrote:

I closed #4 and I created new one. I had to correct one mistake. Sorry for the mess and 3 commits.

That functionality should already be there. If the argument is a dictionary it's used as a dictionary of argument. If its a string, it's treated as a path to an XML document with arguments.

Almost. With my patch there is no need to create xml file externally. I thought this will be more elegant solution to take care of xml file internally. If you think this is not necessary - you can close this pull request. :)

Kamil


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants