Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to junit 5 (junit jupiter) #476

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Upgrade to junit 5 (junit jupiter) #476

merged 2 commits into from
Mar 6, 2019

Conversation

benmccann
Copy link
Collaborator

Thanks for contributing.

Description

Upgraded to JUnit 5 (JUnit Jupiter)

Testing

Ran the existing tests

@lwhite1
Copy link
Collaborator

lwhite1 commented Mar 6, 2019

This is excellent. Junit 5 is such a pleasure compared to 4.
I can see that they're residual rather than new, but would you consider removing the unused imports Codacy is flagging?

@benmccann
Copy link
Collaborator Author

I removed all the star imports, so Codacy is happy now

@lwhite1 lwhite1 merged commit da2d152 into jtablesaw:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants