Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized names for methods, added missing methods #1010

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

lwhite1
Copy link
Collaborator

@lwhite1 lwhite1 commented Oct 10, 2021

Thanks for contributing.

Description

Extending select() to support indexed column access. Select is the non-modifying equivalent of retainColumns().
Rename select() to selectColumns() for consistency
Add rejectColumns() to support the non-modifying (i.e., return a new table) exclusion of columns. This is the equivalent of removeColumns().
Add methods to Relation:

  • ColumnType[] typeArray()
  • List<ColumnType<?> types()
  • containsColumn(String columnName);
    Deprecated method ColumnType[] columnTypes(), because methods with similar names return Lists not Arrays.
    Added method append(Row), and deprecated addRow(Row) so that append() is always the name whether the argument is a table, slice, or row.

Testing

Did you add a unit test?
Yes, and updated the old ones.

@lwhite1 lwhite1 merged commit 32db1ac into master Oct 11, 2021
@lwhite1 lwhite1 deleted the table-enhancements-for-api-rationalization branch October 11, 2021 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant