-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XlsxReader doesn't respect calculated tableArea for header column names #887
Comments
I will be happy to provide a PR for this if it's recognized as an issue. |
If you want to submit a PR with good test coverage, that would be great. |
@lujop Hello, bro, do you still work on this issue? I have encountered the same problem and got some ideas to fix this bug. If you are busy, I can work on this issue. |
Thanks, @DanielMao1, just yesterday I got some time to do some work on a proposition for some reader-related issues that I've not yet finished but I will try to make a PR this weekend. |
OK, here you go. I am not in so hurry to do PR. You can go ahead on this issue anyway :). |
There is a buggy condition on some excels when there are blank columns at the start of the sheet.
When
es.decide.toolbox.util.XlsxReader#createTable
calculates header names it uses afor(Cell cell : row)
instead of using the suppliedtableArea
parameters.And when there are some blank columns it doesn't always work. I don't know exactly why, but sometimes the first blank column is discarded in the iterator, but sometimes although all values are blank poi maintains the column, and the code doesn't work correctly detecting the header column names.
To calculate the header column names the code should use the
tableArea.startColumn
andtableArea.endColumn
The text was updated successfully, but these errors were encountered: